From e3da8c0bceaba091b722d5be736f9d0fe2302823 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Thu, 3 May 2018 22:00:04 -0700 Subject: [PATCH] fix(publisher): remove deprecated option from @octokit/rest params This broke with @octokit/rest.js 15.2.0 ISSUES CLOSED: #493 --- src/util/github.js | 1 - test/fast/github_spec.js | 9 ++------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/util/github.js b/src/util/github.js index c50813affb..04d5189541 100644 --- a/src/util/github.js +++ b/src/util/github.js @@ -4,7 +4,6 @@ import merge from 'lodash.merge'; export default class GitHub { constructor(authToken, requireAuth, options = {}) { this.options = merge( - { protocol: 'https' }, options, { headers: { 'user-agent': 'Electron Forge' } } ); diff --git a/test/fast/github_spec.js b/test/fast/github_spec.js index 71fc80ab32..e8085c25ff 100644 --- a/test/fast/github_spec.js +++ b/test/fast/github_spec.js @@ -46,17 +46,12 @@ describe('GitHub', () => { it('should be able to set the Enterprise URL settings', () => { const gh = new GitHub('1234', true, { - host: 'github.example.com', - port: 8443, - pathPrefix: '/enterprise', + baseUrl: 'https://github.example.com:8443/enterprise', }); const api = gh.getGitHub(); expect(api.options).to.deep.equal({ - protocol: 'https', - host: 'github.example.com', - port: 8443, - pathPrefix: '/enterprise', + baseUrl: 'https://github.example.com:8443/enterprise', headers: { 'user-agent': 'Electron Forge', },