-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate checksum of cached artifacts #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not up-to-speed with all the differences between pre-1.3.2 and post-1.3.4, but the code here looks reasonable
22c8cef
to
4185164
Compare
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The new behavior seems to be always trying to download the checksum file even if all other files are cached. |
This is the new correct/expected behavior.
Right next to the other files you were pre-filling the cache with Worth noting that if you want to do this truly offline without prefilling the SHASUM file you could also provide a |
Fixes #210