-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating node-abi dependency to make electron-rebuild work with electron 15.x properly #886
Comments
We stumbled on this when trying to upgrade to Electron 15. Looks like it should already be fixed in Would you consider publishing a new release that includes this fix? Thanks a lot! 🙂 |
Correction: This appears to have happened already, here: #876. Just waiting on a release! 🤞🏼 |
My bad, I believe the actual fix happened in #848 |
Nudge. Are there plans for a new release? |
Im wating to new release. |
v3.2.5 still throwing the same error. |
As of right now,
electron-rebuild
builds for a wrong node version for mebecause https://github.com/electron/electron-rebuild/blob/master/src/rebuild.ts#L124 gets the abi number from
node-abi
3.0.0, whereas 3.2.0 has support for electron 15.xWorkaround for me right now is to add
to the package.json, which is working and proves the case, but is dirty long-term.
The text was updated successfully, but these errors were encountered: