Re-introduce entity validation for rule types (mindersec#1662)

I don't know why I commented that out, but this re-introduces that check. Closes: mindersec#1659
eleftherias · Nov 15, 2023 · f8d1322 · f8d1322
1 parent 9f8eff5
commit f8d1322
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/api/protobuf/go/minder/v1/validators.go b/pkg/api/protobuf/go/minder/v1/validators.go
@@ -99,9 +99,9 @@ func (rt *RuleType) Validate() error {
 
 // Validate validates a rule type definition
 func (def *RuleType_Definition) Validate() error {
-	// if !entities.IsValidEntity(entities.FromString(def.InEntity)) {
-	// 	return fmt.Errorf("%w: invalid entity type: %s", ErrInvalidRuleTypeDefinition, def.InEntity)
-	// }
+	if !EntityFromString(def.InEntity).IsValid() {
+		return fmt.Errorf("%w: invalid entity type: %s", ErrInvalidRuleTypeDefinition, def.InEntity)
+	}
 
 	if def.RuleSchema == nil {
 		return fmt.Errorf("%w: rule schema is nil", ErrInvalidRuleTypeDefinition)