smtp: fix regression in address type validation #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, let me know when this is out of draft |
zackschuster
force-pushed
the
ø
branch
2 times, most recently
from
117a258
to
30878d9
Compare
|
@eleith i think this is ready but i need to test in azure a bit more before i'm confident |
|
@zackschuster it looks good to me on the surface. |
zackschuster
changed the title
|
@eleith ready |
eleith
approved these changes
Jun 10, 2020
|
@zackschuster i went ahead and merged it. fyi. |
|
@eleith yes, i wanted that. thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in my zeal, i changed truthy checks that allowed arrays for recipients to hard type checks. this PR adds array checks to validation, as well as tests to prevent future regressions.