Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adds basic Linux support, it's building... #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erik-nilcoast
Copy link

I'm not entirely sure how to test this yet, but it does compile now and open in the browser. I need to find the equivalent to setView for the X11 environment, which may be more involved than the simple API provided by macOS and Windows.

@erik-nilcoast erik-nilcoast mentioned this pull request Feb 14, 2024
@nick-thompson
Copy link
Contributor

Fantastic @erik-nilcoast thank you so much! I took a quick pass and generally this looks great. I see what you mean on the view handle piece. I saw this bit in the JUCE docs for that XEmbedComponent:

This is how you embed a GTK+ widget: if you are using the client initiated version of the protocol, then create a new gtk widget with gtk_plug_new (0). Then query the window id of the plug via gtk_plug_get_id(). Pass this id to the constructor of this class.

So I think perhaps, call getViewHandle on the webview, then try to cast it to GtkWidget* (as shown here: https://github.com/Tracktion/choc/blob/main/gui/choc_WebView.h#L332), then perhaps we can use gtk_plug_get_id() from that GtkWidget*? And if so, we can pass it into the constructor for the XEmbedComponent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants