Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips stick around too eagerly #235

Open
nadonomy opened this issue Sep 27, 2023 · 3 comments
Open

Tooltips stick around too eagerly #235

nadonomy opened this issue Sep 27, 2023 · 3 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@nadonomy
Copy link
Contributor

Steps to reproduce

I don't have clear repro steps. But on calls, I notice often tooltips will display themselves long after I've interacted with the button (e.g. when clicking to mute/unmute).

@robintown can you think of any root cause, perhaps how we're handling button focus?

Outcome

...

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No

@nadonomy nadonomy added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Sep 27, 2023
@fkwp fkwp added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Sep 27, 2023
@robintown
Copy link
Member

robintown commented Sep 27, 2023

There's one cause that I'm aware of: if you click a button that opens a modal, such as the Settings button, and then you close the modal, the tooltip will remain visible due to that element now having focus. I think this needs a fix similar to matrix-org/matrix-react-sdk#8546.

@nadonomy Do you remember this happening with the mute/unmute buttons, specifically? Because if so, there must be more to the story since these don't open modals.

@nadonomy
Copy link
Contributor Author

I think so. But, it's been happening while I've been busy in discussion in calls so I might be an unreliable narrator.

I'll try to see if I can get clearer repro steps. Will revert to this issue if I do.

@robintown
Copy link
Member

Related: radix-ui/primitives#1800

@robintown robintown transferred this issue from element-hq/element-call Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

3 participants