Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuItem violates a11y rules #291

Closed
t3chguy opened this issue Dec 15, 2023 · 2 comments · Fixed by element-hq/compound-web#178
Closed

MenuItem violates a11y rules #291

t3chguy opened this issue Dec 15, 2023 · 2 comments · Fixed by element-hq/compound-web#178
Assignees
@t3chguy
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@t3chguy
Copy link
Member

t3chguy commented Dec 15, 2023

image
@t3chguy t3chguy added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Dec 15, 2023
@daniellekirkwood
Copy link

@t3chguy is this all menuitem s? i think you mentioned this in the bounds of the right panel?

@t3chguy
Copy link
Member Author

t3chguy commented Dec 22, 2023 •
edited
Loading

@daniellekirkwood this is an issue with the Compound component, it applies to all usages of said component. Currently Element Web only uses Compound MenuItem in the RoomSummaryCard RightPanel. There's no semantic container component to wrap MenuItems to main accessibility rules

@daniellekirkwood daniellekirkwood mentioned this issue Dec 22, 2023
Open
7 tasks
@t3chguy t3chguy self-assigned this Jun 7, 2024
@t3chguy t3chguy mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve accessibility of MenuItem & ToggleMenuItem element-hq/compound-web
2 participants
@t3chguy @daniellekirkwood