diff --git a/CHANGES.md b/CHANGES.md index ee0d442c795..323eb53485b 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -6,7 +6,7 @@ Features ✨: Improvements 🙌: - Add ability to install APK from directly from Element (#2381) - - Improve login/register flow (#2585, #3172) + - Improve login/register flow (#1410, #2585, #3172) Bugfix 🐛: - Message states cosmetic changes (#3007) diff --git a/vector/src/main/java/im/vector/app/features/login2/LoginFragmentSignupUsername2.kt b/vector/src/main/java/im/vector/app/features/login2/LoginFragmentSignupUsername2.kt index 9a4f0780c58..00b06ed82d0 100644 --- a/vector/src/main/java/im/vector/app/features/login2/LoginFragmentSignupUsername2.kt +++ b/vector/src/main/java/im/vector/app/features/login2/LoginFragmentSignupUsername2.kt @@ -42,10 +42,6 @@ import javax.inject.Inject */ class LoginFragmentSignupUsername2 @Inject constructor() : AbstractSSOLoginFragment2() { - // Temporary patch for https://github.com/vector-im/riotX-android/issues/1410, - // waiting for https://github.com/matrix-org/synapse/issues/7576 - private var isNumericOnlyUserIdForbidden = false - override fun getBinding(inflater: LayoutInflater, container: ViewGroup?): FragmentLoginSignupUsername2Binding { return FragmentLoginSignupUsername2Binding.inflate(inflater, container, false) } @@ -79,10 +75,6 @@ class LoginFragmentSignupUsername2 @Inject constructor() : AbstractSSOLoginFragm views.loginFieldTil.error = getString(R.string.error_empty_field_choose_user_name) error++ } - if (isNumericOnlyUserIdForbidden && login.isDigitsOnly()) { - views.loginFieldTil.error = "The homeserver does not accept username with only digits." - error++ - } if (error == 0) { loginViewModel.handle(LoginAction2.SetUserName(login)) @@ -138,8 +130,6 @@ class LoginFragmentSignupUsername2 @Inject constructor() : AbstractSSOLoginFragm @SuppressLint("SetTextI18n") override fun updateWithState(state: LoginViewState2) { - isNumericOnlyUserIdForbidden = state.isNumericOnlyUserIdForbidden - setupUi(state) } } diff --git a/vector/src/main/java/im/vector/app/features/login2/LoginFragmentToAny2.kt b/vector/src/main/java/im/vector/app/features/login2/LoginFragmentToAny2.kt index 0f62b96d0f8..d865e16e35a 100644 --- a/vector/src/main/java/im/vector/app/features/login2/LoginFragmentToAny2.kt +++ b/vector/src/main/java/im/vector/app/features/login2/LoginFragmentToAny2.kt @@ -51,10 +51,6 @@ class LoginFragmentToAny2 @Inject constructor() : AbstractSSOLoginFragment2 = Uninitialized, - // True on Matrix.org - val isNumericOnlyUserIdForbidden: Boolean = false, - // Network result @PersistState val loginMode: LoginMode = LoginMode.Unknown,