Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threads: Missing preview in thread summary is missing if event not decrypted (incomplete threads) #4681

Closed
daniellekirkwood opened this issue Dec 10, 2021 · 4 comments
Closed

Threads: Missing preview in thread summary is missing if event not decrypted (incomplete threads) #4681

daniellekirkwood opened this issue Dec 10, 2021 · 4 comments
Assignees
@ariskotsomitopoulos
Labels
A-Threads An issue for the Threads project Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 Issue to be released with the Threads MVP

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 10, 2021 •
edited
Loading

Your use case

Missing message preview in thread summary if the event is not decrypted yet.

Solution

  • Reuse the same error messages we use for decryption errors in the main timeline
  • Show the summary, show the same message in the summary if needed

Related: element-hq/element-meta#1925
@daniellekirkwood daniellekirkwood added A-Threads An issue for the Threads project Z-ThreadsP0 Issue to be released with the Threads MVP labels Dec 10, 2021
@daniellekirkwood daniellekirkwood added the Z-ThreadsInternalTesting Issue found while testing Threads internally label Dec 16, 2021
@daniellekirkwood
Copy link
Contributor Author

I think it's OK that the Thread Summary is blank if the message has not yet been decrypted.
@janogarcia do you think we need to have temporary text in the Thread Summary, or being blank is ok for now?

@daniellekirkwood
Copy link
Contributor Author

https://github.com/vector-im/design/issues/8

@janogarcia
Copy link

@daniellekirkwood I discussed this with Aris on the last week before Christmas, but hadn't mentioned it on any specific issue.

I think we should reuse the same error messages we use for decryption errors in the main timeline. While those are not perfect, redesigning how we handle those across the app would be a major undertaking, out of the scope for Threads P0.

@daniellekirkwood
Copy link
Contributor Author

We discussed this issue today in standup and I have updated the issue description.

Let us know if you need anything else @ariskotsomitopoulos

@daniellekirkwood daniellekirkwood mentioned this issue Jan 18, 2022
Closed
@daniellekirkwood daniellekirkwood changed the title Threads: Missing preview in thread summary is missing if event not decrypted Threads: Missing preview in thread summary is missing if event not decrypted (incomplete threads) Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariskotsomitopoulos ariskotsomitopoulos

Labels
A-Threads An issue for the Threads project Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 Issue to be released with the Threads MVP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janogarcia @ariskotsomitopoulos @daniellekirkwood