Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for confirmation when a url with unicode directional characters are present #6163

Closed
ouchadam opened this issue May 26, 2022 · 0 comments · Fixed by #6164
Closed

Ask for confirmation when a url with unicode directional characters are present #6163

ouchadam opened this issue May 26, 2022 · 0 comments · Fixed by #6164
Labels
Security T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@ouchadam
Copy link
Contributor

Your use case

What would you like to do?

Inform the user when they've tapped a potentially misleading URL which contains unicode directional override characters

Why would you like to do it?

To stop potential URL masquerading

How would you like to achieve it?

By reusing the URL confirmation check when a unicode directional override is present in the URL

Have you considered any alternatives?

No response

Additional context

No response
@ouchadam ouchadam added Security T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels May 26, 2022
@ouchadam ouchadam mentioned this issue May 26, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Security T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ask the user to confirm urls which contain unicode direction overrides element-hq/element-android
1 participant
@ouchadam