Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry to-device messages #6689

Closed
Tracked by #673
dbkr opened this issue Jul 29, 2022 · 7 comments
Closed
Tracked by #673

Retry to-device messages #6689

dbkr opened this issue Jul 29, 2022 · 7 comments
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Crypto

Comments

@dbkr
Copy link
Member

dbkr commented Jul 29, 2022

Your use case

Mirroring element-hq/element-web#12851 from web: we should make sure that we retry to-device messages. New impl on web saves them in a queue to persistent storage to be sent when they can be.

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

@dbkr dbkr added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 29, 2022
@jmartinesp jmartinesp added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Sep 6, 2022
@richvdh
Copy link
Member

richvdh commented Nov 16, 2022

Note that this also affects events that are sent when the device is in airplane mode. The events themeselves are queued up; the key shares are simply discarded.

@giomfo
Copy link
Member

giomfo commented Nov 23, 2022

@richvdh When we observed some UTD from android sessions. Is there a specific logs to check to confirm the UTD is relative to this issue or not?

@richvdh
Copy link
Member

richvdh commented Nov 23, 2022

I think there will likely be something like this in the sender's log:

2022-11-09T07:42:55*539GMT+00:00Z 63 E/ /CRYPTO/MXMegolmEncryption: shareUserDevicesKey() : Failed to share <grImQSHhxflgfJfX8qzKouKx5BIao3rJZWIK7A9VL70>

@jdauphant
Copy link
Contributor

Any news an when this will be implemented?
This will have a major impact reducing on UTD ?

Cc @giomfo @Florian14 @yostyle

@BillCarsonFr
Copy link
Member

Closing, as will be fixed by intregrating the rust SDK

@dead10ck
Copy link

dead10ck commented Apr 8, 2023

Closing, as will be fixed by intregrating the rust SDK

Is that done yet, though?

@Florian14
Copy link
Contributor

Closing, as will be fixed by intregrating the rust SDK

Is that done yet, though?

Not yet, all the changes are on this branch and should be merged soon into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Crypto
Projects
None yet
Development

No branches or pull requests

9 participants