Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant heading from bug report issue form #4048

Closed
wants to merge 2 commits into from
Closed

Remove redundant heading from bug report issue form #4048

wants to merge 2 commits into from

Conversation

opusforlife2
Copy link
Contributor

@opusforlife2 opusforlife2 commented Sep 20, 2021

Pull Request Checklist

The issue form currently generates a bug report that contains the "What happened?" heading twice. See #4047 (comment). This splits the two questions off into their own (compulsory) text boxes.

The report generated by the issue form had an empty repeated subheading because the label and value contained the same question twice.
@opusforlife2
Copy link
Contributor Author

This PR doesn't need the CI checks. Changes to peripheral files, like issue templates, can be made to be ignored by the CI. See TeamNewPipe/NewPipe#6789.

@bmarty
Copy link
Member

bmarty commented Sep 23, 2021

This is the opposite PR of #3960.
Please see the discussion there about why we made it.

@kittykat
Copy link
Contributor

Indeed, I prefer to have two sections but we compromised on one section to encourage all developers to fill in the issues in the same way that they would like users to do. Please feel welcome to propose better wording for one section. We want to explicitly prompt the issue filer to tell us what they were expecting and what happened.

(Also the ### need to be changed to ####)

Once we settle on wording, the same updates will need to be made against element-web (web and desktop templates) and element-ios

@bmarty bmarty closed this Sep 24, 2021
@opusforlife2 opusforlife2 deleted the issue_template branch September 24, 2021 15:51
@opusforlife2
Copy link
Contributor Author

Ah. Oops. I missed that PR.

I'll open a new one without splitting the textarea. 👍

@opusforlife2
Copy link
Contributor Author

New PR #4076.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants