Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riot-web installs a setuid root binary #754

Open
foresto opened this issue Jan 22, 2020 · 1 comment
Open

riot-web installs a setuid root binary #754

foresto opened this issue Jan 22, 2020 · 1 comment
Labels

Comments

@foresto
Copy link

foresto commented Jan 22, 2020

Description

On linux, the riot-web package installs /opt/Riot/chrome-sandbox as suid root, granting it superuser privileges to my entire system. This is a security risk.

I realize that this is probably baggage from Electron, but I do not particularly trust Electron or Chromium with system level privileges, and frankly, nobody should be expected to do so just for a chat application. Especially one so focused on privacy and security.

Version information

  • Platform: desktop
  • OS: Xubuntu Linux
  • Version: 1.5.7
@foresto foresto changed the title riot-web installs a suid root binary riot-web installs a setuid root binary Jan 22, 2020
@jryans
Copy link
Contributor

jryans commented Jan 23, 2020

Yes, you guessed correctly, it's required by the Chromium sandboxing approach that Electron inherits. element-hq/element-web#10509 (comment) provides a summary of the available options, both of which aren't very palatable.

I don't think Riot itself has much choice here unless Chromium makes a change or the desktop app is entirely rebuilt with [insert other tech stack here].

@t3chguy t3chguy transferred this issue from element-hq/element-web Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants