Allow loading language files with two part language code

[TPiUnikie]

Change the imported filenames to inlcude underscore in two part language names. #871

Signed-off-by: Timo Piiroinen timo.piiroinen@unikie.com

---

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Allow loading language files with two part language code (#339). Contributed by @TPiUnikie.

[dbkr]

A few things about this function:

• The if branch is redundant? The code only does the split if the string contains a hyphen, so we know we'll get at least two parts.
• Having langDesc & partsReq as defined constants I think might be adding more confusion. I'd probably just use the numbers straight in the code (if partsReq is even necessary).
• Maybe parts instead of part for the variable - it's all the parts of the split string
• Could it get a comment saying what it does?

[TPiUnikie]

• The first if was like a guard to avoid variables to be reserved if there is no hyphen, maybe those will be optimized out?
• maybe langDesc rename to localeIndex. Currently the second part is for uppercase.
  If there are cases like aa_bb_cc, then it would output aa-BB-cc, using last index: aa-bb-CC.
• Parts would be a better name
• partsReq can be removed, if change the > langDesc is changed to comparison

[dbkr]

Thanks, although I'm not sure the if is really optimising anything: variables are very cheap, so this will probably spend more time searching through the string twice. In any case, it would be a tiny optimisation: code legibility is much more important. I don't really mind though, although if you do want to do it then we should do it with the more modern includes() rather than indexOf().

Also I'm afraid I still don't understand the need for the localeSubIndex const: any actual constants should be near the top of the file above the class, but for the second thing in an array you can just say parts[1] which is clearer and more concise.

A comment on the function saying what it does would still be very useful ('denormalize' doesn't really tell me what the function is supposed to do).

[TPiUnikie]

Added comment
Removed the 'if' check
Used fixed index numbers instead of defined constant

[dbkr]

I've also changed the tense of the PR title to match the standard for our changelogs.

[dbkr]

Thanks for making those changes, to me this is a lot easier to understand.