Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication: Be more open for login flows #3711

Closed
manuroe opened this issue Oct 1, 2020 · 3 comments
Closed

Authentication: Be more open for login flows #3711

manuroe opened this issue Oct 1, 2020 · 3 comments
Milestone
Sprint 31

Comments

@manuroe
Copy link
Member

manuroe commented Oct 1, 2020

The code has a very old restriction where all login (or registration) flows exposed by the HS must be supported.
It was used to detect CAS and SSO before SSO was specified in the matrix spec.

The code at https://github.com/matrix-org/matrix-ios-kit/blob/v0.12.21/MatrixKit/Controllers/MXKAuthenticationViewController.m#L721-L730 should be removed.
@manuroe manuroe added this to the Sprint 31 milestone Oct 1, 2020
@SBiOSoftWhare SBiOSoftWhare mentioned this issue Oct 1, 2020
Merged
@richvdh
Copy link
Member

richvdh commented Oct 8, 2020

@manuroe is this now fixed?

@richvdh richvdh mentioned this issue Oct 8, 2020
Merged
@clokep clokep mentioned this issue Oct 8, 2020
Merged
@anoadragon453
Copy link
Member

anoadragon453 commented Oct 9, 2020 •
edited
Loading

This has been fixed in matrix-org/matrix-ios-kit@1638b54, and should be in the next release according to @manuroe.

@manuroe
Copy link
Member Author

manuroe commented Oct 9, 2020

True. It will be available on 1.0.15.

@manuroe manuroe closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 31
Development

No branches or pull requests
3 participants
@anoadragon453 @richvdh @manuroe