Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new Thread by replying to a message in Timeline #5068

Closed
3 tasks
daniellekirkwood opened this issue Nov 1, 2021 · 5 comments · Fixed by #5089
Closed
3 tasks

Start a new Thread by replying to a message in Timeline #5068

daniellekirkwood opened this issue Nov 1, 2021 · 5 comments · Fixed by #5089
Assignees
Labels
A-Threads Message threading to simplify the Timeline Z-ThreadsP0 The first milestone for Threads

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Nov 1, 2021

As a user I want to start a new Thread from a message in the Timeline.

Short tap on message to open options > start Thread is an option
Design: Starting a new thread. Case: Initiated by a short tap on a message.

Short press to reveal the thread view is not included in the MVP/P0 version of Threads.

Following matrix-org/matrix-spec-proposals#3440

  • Use relation type m.thread to start Threads
  • Make sure that m.thread can be combined with m.in_reply_to to allow quote relies in threads

Added:

  • When user taps "Thread" on the tab bar the message composer gets the focus so user can type reply immediately without the need for extra tap
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Threads Message threading to simplify the Timeline Z-ThreadsP0 The first milestone for Threads X-Needs-Design May require input from the design team X-Needs-Product Requires input from the product team labels Nov 1, 2021
@daniellekirkwood daniellekirkwood removed the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 1, 2021
@ismailgulek ismailgulek self-assigned this Nov 1, 2021
@daniellekirkwood
Copy link
Contributor Author

Needs-Product is a label on this issue because we need to reach a conclusion on the Short Press discussion.

@daniellekirkwood daniellekirkwood self-assigned this Nov 1, 2021
@pixlwave pixlwave added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 1, 2021
@pixlwave pixlwave removed the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 1, 2021
@pixlwave
Copy link
Member

pixlwave commented Nov 1, 2021

Sorry, just saw you removed that tag already.

@daniellekirkwood
Copy link
Contributor Author

Removing the Needs-Product label as we're moving Short Press to Post-Launch.
Removing the Needs-Design label as we now have a PR for Design to review.

@daniellekirkwood daniellekirkwood removed X-Needs-Design May require input from the design team X-Needs-Product Requires input from the product team labels Nov 12, 2021
@daniellekirkwood daniellekirkwood removed their assignment Nov 12, 2021
@janogarcia
Copy link

janogarcia commented Jan 11, 2022

@ismailgulek We need to make sure that when the "Thread" action is used the message composer input gets the focus automatically in the thread view, without requiring the user to manually tap on it to actually initiate the reply.

Just to be clear, that behavior should only happen when following the "Thread" action. This doesn't apply when just viewing a thread after tapping on a thread summary or a thread tile in the thread list.

https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=2265%3A256789


🗒 A side note for a future improvement: The "Thread" action should actually be a verb, like "Reply in thread", instead of a noun (it's unclear what would be the outcome of that button just by reading its label... would it just show a thread? maybe initiate a reply?).

The thing is that unless we move all the actions to a bottom sheet (as we do for Android) instead of using a Tab Bar style component, then it won't be possible for us to have such meaningful labels for the primary actions. Hopefully we can tackle that in the future, bringing a more coherent experience across platforms.

@janogarcia
Copy link

janogarcia commented Jan 11, 2022

Could you please add it as a task/acceptance criteria to the issue description? Thanks!

@daniellekirkwood I edited the issue description for you. This time it was editable by me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads Message threading to simplify the Timeline Z-ThreadsP0 The first milestone for Threads
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants