Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crosssigning between iOS and Android - iOS can't scan Android (or iOS) QR Code #7660

Closed
lampholder opened this issue Aug 31, 2023 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1816
Closed

Crosssigning between iOS and Android - iOS can't scan Android (or iOS) QR Code #7660

lampholder opened this issue Aug 31, 2023 · 2 comments · Fixed by matrix-org/matrix-ios-sdk#1816
Labels
A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@lampholder
Copy link
Member

Steps to reproduce

Originally tested between:

  • iOS Element 1.11.0, and
  • Android Element 1.6.5
  1. User is logged in with iOS
  2. User logs in with Android
  3. Android starts crosssigning
  4. iOS Scans Android QR code
  5. iOS fails to scan the QR code but shows “Wait for other device” Screen
  6. On iOS: Rust function scanQRCode returns nil

Outcome

What did you expect?

  • iOS can scan Android QR Code
  • if iOS can’t scan Android QR Code the correct error is shown

Your phone model

No response

Operating system version

No response

Application version

Element iOS 1.11.0

Homeserver

No response

Will you send logs?

No
@lampholder lampholder added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 31, 2023
@lampholder
Copy link
Member Author

Subsequently tested between two iOS devices also failed.

@Velin92 Velin92 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 4, 2023
@BillCarsonFr BillCarsonFr mentioned this issue Sep 8, 2023
Closed
@BillCarsonFr
Copy link
Member

This happens because the base64 encoded data passed to the SDK has padding, and the sdk is to strict and reject the code because of that.
Created an issue to be more lax on sdk side, matrix-org/matrix-rust-sdk#2531, and looking at not passing a padded version to SDK

@BillCarsonFr BillCarsonFr mentioned this issue Sep 8, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
Issue triage
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix passing padded base64 instead of unpadded matrix-org/matrix-ios-sdk
3 participants
@lampholder @BillCarsonFr @Velin92