Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synapse Admin API: Last seen timestamp also in list users endpoint #1982

Closed
yncyrydybyl opened this issue Aug 14, 2023 · 8 comments · Fixed by matrix-org/synapse#16218
Closed

Comments

@yncyrydybyl
Copy link
Member

Your use case

What would you like to do?

Description

As a admin I want to see when a user was active the last time without looking up every device.

With the User List Accounts endpoint you can get a list of all users.
How much work would it be to add the last_seen_ts field from the
List all devices Endpoint to the above API and take the latest last_seen_ts value from all devices registered to the user?

Have you considered any alternatives?

No response

Additional context

No response

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Aug 14, 2023

Screenshot 2023-08-14 at 12 34 24

@yncyrydybyl Already done :) 👍

@pmaier1
Copy link
Contributor

pmaier1 commented Aug 31, 2023

@yncyrydybyl Already done :) 👍

I think this isn't what they are asking for. They want to see the latest last_seen_ts from a particular device in the response of the List Accounts endpoint.

@pmaier1 pmaier1 reopened this Aug 31, 2023
@wrjlewis wrjlewis assigned wrjlewis and MatMaul and unassigned wrjlewis Aug 31, 2023
@daniellekirkwood
Copy link
Contributor

take the latest last_seen_ts value from all devices registered to the user

This is how I may have misinterpreted the ask. I believe @yncyrydybyl was asking for "when a user was active the last time without looking up every device" which we have in the profile.

We also have a list of devices in the profile and could add the last seen TS to that view fairly easily (I don't know how this works with MAS etc.) Is that what this issue now represents?

Could we get designs into the description of this issue? I'm a little lost as to what the Admin Console folks will need to work on vs the backend team :)

@daniellekirkwood
Copy link
Contributor

Screenshot 2023-08-31 at 18 33 48

This is the design we were given --

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Aug 31, 2023

Screenshot 2023-08-31 at 18 37 19

This is what we have in the product (close as we could get to the design).

Let me know where I've missed a beat in the original ask! (other than the need to make that TS a time-stamp!)

@MatMaul
Copy link

MatMaul commented Sep 1, 2023

@daniellekirkwood I think you are talking about having it in the console admin UI, while I think this request is for the Synapse admin API I believe.

For the UI you can then use that to have this value directly in the list of users instead of only the user details. I am also adding a sort parameter, so you will also be able to use that.

@pmaier1
Copy link
Contributor

pmaier1 commented Sep 1, 2023

this request is for the Synapse admin API I believe.

Yes, this is API only. No changes in admin console needed. With MAS, this needs to be implemented as well. But this ask is for the Synapse admin API today.

@daniellekirkwood
Copy link
Contributor

Thank you :D I'm still learning - appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants