Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message keys withheld due to "Never send encrypted messages to unverified sessions from this session" are not shown as such #2450

Open
1 of 3 tasks
Tracked by #245
kegsay opened this issue Jun 20, 2024 · 3 comments
Labels

Comments

@kegsay
Copy link

kegsay commented Jun 20, 2024

Element-Web, Android and iOS all have the ability to enable a security flag which says something like:

Never send encrypted messages to unverified sessions from this session

This can cause UTDs if the recipient has not been verified yet. We should really be displaying warning banners if there are unverified devices in the room when you are typing a message, to warn the sender that this message will be undecryptable for some devices/users.

This appears at the protocol level as a "withheld" to-device message - https://spec.matrix.org/latest/client-server-api/#reporting-that-decryption-keys-are-withheld with the code of m.unverified.

@kegsay kegsay added the A-E2EE label Jun 20, 2024
@BillCarsonFr
Copy link
Member

This is actually a expected UTD, we should probably report it as such.
Check that we properly display the withheld code to the user, if not it's bug.

@richvdh
Copy link
Member

richvdh commented Jun 27, 2024

Can confirm this doesn't work correctly in Web: element-hq/element-web#27653

@richvdh
Copy link
Member

richvdh commented Aug 5, 2024

element-hq/element-web#27653 is now fixed, and EW now shows "The sender has blocked you from receiving this message because your device is unverified".

However, this remains a problem in Element iOS (element-hq/element-ios#7825) and Element X.

@richvdh richvdh changed the title The UX when "Never send encrypted messages to unverified sessions from this session" is enabled is bad and can cause unexpected UTDs Message keys withheld due to "Never send encrypted messages to unverified sessions from this session" are not shown as such Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants