Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/rainbowme 💩 causes server error #10368

Closed
uhoreg opened this issue Jul 19, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3248
Closed

/rainbowme 💩 causes server error #10368

uhoreg opened this issue Jul 19, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3248
Assignees
@t3chguy
Labels
P3 T-Defect Z-Community-PR Issue is solved by a community member's PR Z-Power-Users

Comments

@uhoreg
Copy link
Member

uhoreg commented Jul 19, 2019

because 💩 spans two utf-16 units, and they end up getting split up by the font tags from /rainbowme, resulting in invalid unicode. Because utf-16 is a pain. (ref https://matrix.to/#/!iNmaIQExDMeqdITdHH:matrix.org/$1563499702139761sobfL:matrix.org?via=matrix.org&via=privacytools.io&via=linuxgaming.life )
@turt2live
Copy link
Member

Related: #9794 (comment)

@t3chguy
Copy link
Member

t3chguy commented Jul 19, 2019

Rainbow emoji sure does look cool though
image

@t3chguy t3chguy mentioned this issue Jul 25, 2019
Merged
@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
P3 T-Defect Z-Community-PR Issue is solved by a community member's PR Z-Power-Users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix /rainbowme and /rainbow breaking apart utf-16 emoji matrix-org/matrix-react-sdk
4 participants
@jryans @uhoreg @turt2live @t3chguy