Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to disconnect from an integration manager entirely in the same way that we support doing this for identity servers #10696

Closed
lampholder opened this issue Aug 30, 2019 · 7 comments

Comments

@lampholder
Copy link
Member

No description provided.

@turt2live
Copy link
Member

This is tricky because of the 3 levels users can have integration managers at: Riot config, homeserver config, and account data. The button would need to store a flag to ignore the settings.

@afonari
Copy link

afonari commented Oct 7, 2019

This is important for privacy, please prioritize.

@turt2live
Copy link
Member

We've spent several hours to try and figure out what this means and it's not as trivial as we want. Removing an integration manager means (to us):

  • Hiding the integrations button in the room
  • Hiding the sticker picker button (for UX, not because we have to - it's a widget)
  • Avoiding the use of a whitelist for widget URLs, therefore exposing the integration manager wrapper in widgets
    • This may require design for a "show more info" button to expose the query string
  • Hoping widgets are capable of auth, potentially adding more work for us later: Investigate why Scalar requires auth for things (and see if we can fix it) #11085

Where we store this flag is moderately unknown - account data?

@afonari
Copy link

afonari commented Oct 8, 2019

I don't know the code base that well, but can't you just check if the host is not empty and accessible and based on this do all this things.

@turt2live
Copy link
Member

no, because there's 3 levels of integration manager configuration and none of which permit a "none" option. The disconnect button is additionally per-user, so we need to be able to detect that and that's difficult.

@turt2live
Copy link
Member

also: we've proposed matrix-org/matrix-spec-proposals#2315 to solve the disconnection problem.

@turt2live
Copy link
Member

After some long and plentiful discussions, it's not quite possible for us to offer a "disconnect" in the same way. We are however going to offer a way for users to say they don't want to use an integration manager for provisioning, which is to say it won't break the app but also prevent you from doing certain things that involve the integration manager.

See #11354 and referenced issues for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants