Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to verification in DMs #11251

Closed
4 of 5 tasks
dbkr opened this issue Oct 28, 2019 · 1 comment
Closed
4 of 5 tasks

Switch to verification in DMs #11251

dbkr opened this issue Oct 28, 2019 · 1 comment
Assignees

Comments

@dbkr
Copy link
Member

dbkr commented Oct 28, 2019

Scope of this issue is to switch verification events from going over to_device events to being sent in DM rooms. Some UI will be needed for this, eg. a prompt to create a new DM if the user doesn't already have one with both people in.

  • Add a labs flag for verification in DMs.
  • Support incoming verifications both in DMs and old to_device messages. If the labs flag is on, initiate verifications using DMs (interface in verification in DMs matrix-org/matrix-js-sdk#1050)
  • Once other clients support verif over DMs, remove labs flag & always send over DM.
  • Add tiles for verification events in rooms (nb. I think we should only show the events if we'd start a verification from them, eg. if we see verif events in non-DM rooms or for nonmatching users, just don't display anything).
  • Any other UI necessary, eg. prompt to start a DM if there isn't one we can use.
  • Verifications will still pop up in a dialog for now: nag bar / verif in side panel are separate tickets and can be decoupled (unless it makes sense todo them together).
@bwindels
Copy link
Contributor

bwindels commented Oct 29, 2019

@dbkr What is this ticket about exactly? About using requestVerificationDM and acceptVerificationDM from the js-sdk PR in react-sdk? Or is this a meta ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants