Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't loop presence calls when they fail #13877

Closed
turt2live opened this issue Jun 1, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11223 or matrix-org/matrix-react-sdk#11824
Closed

Don't loop presence calls when they fail #13877

turt2live opened this issue Jun 1, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11223 or matrix-org/matrix-react-sdk#11824
Assignees
@t3chguy
Labels
A-Performance A-Presence Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect

Comments

@turt2live
Copy link
Member

With all the new server implementations, many of them skip presence for the first while. This leads to a sea of console errors and a boatload of failed requests. Surely we should back off when we get 404s, 500s, etc.
@turt2live turt2live added T-Defect A-Performance S-Tolerable Low/no impact on users Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 13, 2022
@t3chguy t3chguy self-assigned this Jul 11, 2023
@t3chguy t3chguy mentioned this issue Jul 11, 2023
Merged
@andybalaam
Copy link
Member

We've had to revert the fix for this pending a Synapse update: matrix-org/matrix-react-sdk#11365

@andybalaam andybalaam reopened this Aug 3, 2023
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
@t3chguy t3chguy mentioned this issue Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Performance A-Presence Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
5 participants
@andybalaam @MadLittleMods @Johennes @turt2live @t3chguy