Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room Preview buttons have a contrast ratio of 2.4:1 when it should be 3:1 #14731

Closed
turt2live opened this issue Jul 23, 2020 · 4 comments
Closed

Room Preview buttons have a contrast ratio of 2.4:1 when it should be 3:1 #14731

turt2live opened this issue Jul 23, 2020 · 4 comments
Labels
A11y

Comments

@turt2live
Copy link
Member

Green buttons are bad with white text
@erikkroes
Copy link

Everywhere where mint meets white or grey, it's going to be a challenge. Implementing aXe like in #14732 might find a lot of these. If there's a style guide or something alike, it's worth to double check it for usable combinations.

@t3chguy
Copy link
Member

t3chguy commented Jul 23, 2020

Duplicate of #14501

@t3chguy t3chguy marked this as a duplicate of #14501 Jul 23, 2020
@t3chguy t3chguy closed this as completed Jul 23, 2020
@t3chguy
Copy link
Member

t3chguy commented Jul 27, 2020

Re-opening as #14501 was re-scoped to just be for the heading for release urgency

@t3chguy t3chguy reopened this Jul 27, 2020
@t3chguy t3chguy added the I18n label Jul 27, 2020
@jryans jryans added A11y and removed I18n labels Mar 5, 2021
@t3chguy t3chguy mentioned this issue Apr 12, 2023
Closed
@germain-gg
Copy link
Contributor

Fixed by matrix-org/matrix-react-sdk#11079 we're now using a different shade a green that meets accessibility requirements

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11y
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @germain-gg @turt2live @t3chguy @erikkroes