Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History in a recently created room is silently hidden from new members #16074

Open
joepie91 opened this issue Jan 5, 2021 · 7 comments
Open

History in a recently created room is silently hidden from new members #16074

joepie91 opened this issue Jan 5, 2021 · 7 comments
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Chronic Z-Confidence-High High confidence in the enhancement or suggestion based on known factors, or as described. Z-Synapse

Comments

@joepie91
Copy link

joepie91 commented Jan 5, 2021 •
edited
Loading

Description

Joining as a new user in a room with private room history, gives no indication that this is the case; the room just looks empty and dead.

From the perspective of someone already in the room:

Selection_366

And then from the perspective of a new user:

Selection_367

Steps to reproduce

  • Create a room that has history set to "members only from when they joined"
  • Say something in the room
  • Join from another user
  • See an empty room, no history, nor any indication that history was elided

This should include a clear indicator that the room history is being hidden, so that the user understands that there may have been conversational history (and the room isn't dead), they just can't see it. Similar to how there's a clear "this room uses E2EE" indicator after joining it, really.

In fact, I'd argue that the "this is the start of the room" without an elided-history marker is actively misleading to users, as it almost explicitly says that there isn't something being elided!

Logs being sent: no

Version information

  • Platform: web/desktop, specific versions not relevant - it's just a missing feature
@jryans jryans removed defect labels Mar 4, 2021
@robintown
Copy link
Member

So I would like to solve this in matrix-org/matrix-react-sdk#5887, but I'm not even sure API-wise how to detect there being hidden history in this case, since the homeserver silently returns the room creation event as if that's all there is. Could someone with more knowledge of the spec please explain why the room creation events are even given to the client in this case? (Shouldn't they be hidden as well?)

@robintown
Copy link
Member

robintown commented May 4, 2021 •
edited
Loading

Hmm, I just tried reproducing this with Dendrite instead of Synapse and I couldn't. Instead, Dendrite seems to be hiding the room creation events as I hoped it would, leading me to believe that the specific scenario you're seeing above is a Synapse bug.

As for showing a message when history is hidden, that will be resolved by matrix-org/matrix-react-sdk#5887.

@robintown robintown mentioned this issue May 4, 2021
Open
@robintown
Copy link
Member

Opened matrix-org/synapse#9923

@novocaine novocaine added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed S-Tolerable Low/no impact on users labels Aug 19, 2021
@kittykat kittykat added X-Needs-Community-Testing S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed P2 X-Needs-Community-Testing S-Minor Impairs non-critical functionality or suitable workarounds exist labels Dec 16, 2021
@kittykat
Copy link
Contributor

kittykat commented Dec 21, 2021 •
edited
Loading

I'm upgrading severity after discussing with Faye because this is highly annoying

@novocaine novocaine mentioned this issue Jan 11, 2022
Open
4 tasks
@nadonomy
Copy link
Contributor

+1 to exposing this when joining a room, once we support it.

@robintown
Copy link
Member

Removing X-Needs-Design since we already have designs in place for when history is hidden, it's just a matter of getting the Synapse bug fixed.

@robintown robintown changed the title Hidden/private room history should be made obvious to new users History in a recently created room is silently hidden from new members Aug 10, 2022
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 22, 2022
@MadLittleMods
Copy link
Contributor

Related to MSC3871: Gappy timelines

@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Chronic Z-Confidence-High High confidence in the enhancement or suggestion based on known factors, or as described. Z-Synapse
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kittykat @novocaine @jryans @MadLittleMods @joepie91 @nadonomy @robintown