Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[design] Alter the (@user:server.net) suffix on duplicated displaynames to be "out of band" of the displayname itself #16897

Closed
ShadowJonathan opened this issue Apr 9, 2021 · 5 comments · Fixed by matrix-org/matrix-react-sdk#5880

Comments

@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Apr 9, 2021

I feel like i can best describe this with the comparison between two images:

image
And;
image

The first image describes the current behaviour, the second one the behaviour I want; I'd want for the (@user:server.net) suffix of displaynames to be reworked so this displays as a "tag" instead (such as discord's "BOT" labels:
image
But meant to be less "visible"

That mockup was generated with:

color: grey;
font-size: 80%;
font-family: monospace;
margin-left: 1px;

Plus placing the (@user:server.net) manually in <span> tags, and then applying above CSS to the specific span.

(A bug variant of this request is #16896, which describes specific behaviour when a user detail sidebar is opened on the right)

@ShadowJonathan ShadowJonathan changed the title [design] Alter the (@user:server.net) suffix on duplicated displaynames to be "out of band" of the displayname itself [design] Alter the (@user:server.net) suffix on duplicated displaynames to be "out of band" of the displayname itself Apr 9, 2021
@ShadowJonathan
Copy link
Contributor Author

Alternate configuration where the username is "under" the displayname, like so:
image

@niquewoodhouse
Copy link

I personally really like this idea because it seems small to do and is hopefully high reach (hopefully most users view a populated timeline) and makes it easier to read every timeline, which is pretty important.

Somethings I don't quite understand:

  • Are the brackets necessary for some reason around the (@user:server.net)? If so, what are they doing?
  • Sometimes in my timeline I see people who don't have their (@user:server.net)bit, and just a name

image

vs

image

Do we know the reasons as to why that might happen, I'm totally guessing it's something configured on the homeserver, or by a user in their settings?

I was seperately wondering if, longer-term, forcing the (@user:server.net) to be visible on tapping/hovering on the user in a small pop up was as useful/might be the right place for it where you can take more actions (eg message/ignore etc)

Discord example
image

Slack example
image

@t3chguy
Copy link
Member

t3chguy commented Apr 16, 2021

The appended bit in brackets is a disambiguation, it only shows up for users whose display name in that room is not unique

Its to help prevent malicious acts which try and confuse you into believing a person is someone different by them setting their name+avatar to match someone you trust

@SimonBrandner
Copy link
Contributor

Are the brackets necessary for some reason around the (@user:server.net)? If so, what are they doing?

I don't think they are if a different enough styling would be used. But if we decided to have them I'd like to use the suggested square brackets (Šimon Brandner [@simon.brandner:envs.net]) because it nicely matches the Matrix logo ([matrix])

@ShadowJonathan
Copy link
Contributor Author

ShadowJonathan commented Apr 16, 2021

@niquewoodhouse I should note that the disambiguation side of things is noted in the spec, while i feel that in this case it's more of an implementation detail (hiding as a recommendation), this could be open for design and discussion.

But if we decided to have them I'd like to use the suggested square brackets (Šimon Brandner [@simon.brandner:envs.net]) because it nicely matches the Matrix logo ([matrix])

Agreed, I think bracket disambiguation looks nice when styling 👀

FTR, discord somewhat goes around the "malicious users" thing by implementing a bunch of other implicit trust-relationship methods, such as the Friend system, having users set special colors for admin roles (that stand out against the white), and using # disambiguation with usernames. All-in-all it creates tools for a user to verify someone with, even if it's needing to be explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants