Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix room upgrade UX before suggesting room upgrades in Spaces #18676

Closed
turt2live opened this issue Aug 20, 2021 · 5 comments
Closed

Fix room upgrade UX before suggesting room upgrades in Spaces #18676

turt2live opened this issue Aug 20, 2021 · 5 comments
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@turt2live
Copy link
Member

The UX is terrible and users are completely unaware of the consequences of upgrading, such as bridges and bots not working, settings not being transferred over, and membership being finicky. A single button press should not upgrade the room without context to the user.
@ramsey
Copy link

ramsey commented Aug 20, 2021

I was perusing the options in the latest version of Element and thought this "Upgrade Required" was a link to more information about upgrading. When I clicked it, nothing happened. So, I thought I failed to click it properly, so I clicked it again a couple of times. After returning to my room, I was presented with the standard "This room has been upgraded. The conversation continues here." link, which takes me to my new v8 room. Oops!

Screen Shot 2021-08-20 at 12 11 24

@novocaine
Copy link
Contributor

novocaine commented Aug 20, 2021 •
edited
Loading

👋 it would have been easier to triage this if it had been filed using the bug template as that would have included a breakdown of actions taken and expected behaviour, and whether you were using stable or develop, where this is a moving target.

The current behaviour.. when you click on the Space members radio button, this warning appears

Screenshot 2021-08-20 at 13 54 54

We can alter this copy to reflect better the ramifications of upgrading the room version (bridges, bots).

I'm wondering from the original description if this didn't show up somehow, as it hasn't been mentioned, and it mentions "A single button press should not upgrade the room without context to the user."

@novocaine
Copy link
Contributor

I was perusing the options in the latest version of Element and thought this "Upgrade Required" was a link to more information about upgrading. When I clicked it, nothing happened. So, I thought I failed to click it properly, so I clicked it again a couple of times. After returning to my room, I was presented with the standard "This room has been upgraded. The conversation continues here." link, which takes me to my new v8 room. Oops!

Screen Shot 2021-08-20 at 12 11 24

@ramsey I can't reproduce this on https://app.element.io - when I click on either the radio itself or the Upgrade Required label, it shows the above dialog. And it definitely shouldn't upgrade without you clicking upgrade. Did you see this dialog? Are you on stable or develop?

@novocaine novocaine added A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Info This issue is blocked awaiting information from the reporter labels Aug 20, 2021
@novocaine
Copy link
Contributor

Possibly related to weirdness noted in #18677

@t3chguy t3chguy added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 14, 2022
@turt2live
Copy link
Member Author

We can alter this copy to reflect better the ramifications of upgrading the room version (bridges, bots).

ftr, the suggestion of this issue is to literally not have the upgrade button at all. It's not really stable behaviour.

We've since committed to having it though so there's not really a point in trying to die on this hill, spec-wise.

@ramsey I think your issue is entirely unrelated and may be deserving of a dedicated issue, if you're still seeing it.

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ramsey @novocaine @turt2live @t3chguy