Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New threads are not properly shown in the Main Timeline (room) #19395

Closed
Palid opened this issue Oct 14, 2021 · 3 comments
Closed

New threads are not properly shown in the Main Timeline (room) #19395

Palid opened this issue Oct 14, 2021 · 3 comments
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@Palid
Copy link
Contributor

Palid commented Oct 14, 2021

Steps to reproduce

  1. Login with two different accounts and join the same room (Alice and Bob)
  2. Write a message from any of those account (Bob)
  3. Create a thread with the same account (Bob)
  4. Expect that on the second account (Alice) you will have the message with a thread

Outcome

What did you expect?

A threaded message, as the Bob account created

What happened instead?

The thread was not created

Problems analysis:

  1. EventTile.tsx is not properly listening for thread events updated, see: Fix threads not rendering properly in main timeline matrix-org/matrix-react-sdk#6929 (this pull request on itself does not fix the problem, as model is broken)
  2. matrix-js-sdk/src/models/thread.ts:77 - the root is always overriden when getting a new thread with the first reply event, instead of the actual thread's root.
  3. The proper root event (which in this case would be event.replyEventId, matrix-js-sdk/src/models/thread.ts:77) has not been added to the Thread's timeline, which means that event.rootEvent never exists and threads can't render

Operating system

No response

Browser information

No response

URL for webapp

No response

Homeserver

No response

Will you send logs?

No

@Palid Palid added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Threads labels Oct 14, 2021
@Palid
Copy link
Contributor Author

Palid commented Oct 14, 2021

This issue is also responsible for threads sometimes not rendering properly in the main timeline on initial sync.

@germain-gg
Copy link
Contributor

To test again after matrix-org/matrix-react-sdk#6949 lands

@germain-gg
Copy link
Contributor

Fixed as part of matrix-org/matrix-react-sdk#6952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants