Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Root Messages shows Expand/Collapse in Thread List view #19765

Closed
daniellekirkwood opened this issue Nov 16, 2021 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7221
Assignees

Comments

@daniellekirkwood
Copy link
Contributor

Your use case

When a Root message is deleted, the delete event shows in the Thread List view where instead the Thread should show and in place of the Root message it should read "Message deleted"

@janogarcia I'm sure you have a design Figma for this, could you link it please?


Screenshot 2021-11-15 at 14 51 41


Screenshot 2021-11-15 at 14 52 26


Screenshot 2021-11-15 at 14.48.55

Have you considered any alternatives?

No response

Additional context

No response

@janogarcia
Copy link

janogarcia commented Nov 17, 2021

@daniellekirkwood Sure, I'm adding a link to Figma for reference. The actual issue here is that, when there's multiple contiguous deleted root messages in the Thread List, those are being automatically collapsed as in the room timeline, which shouldn't happen in the context of the Thread List.

Flow — Deleting the root message

@germain-gg germain-gg changed the title Threads: Deleting Root Messages shows Expand/Collapse in Thread List view Deleting Root Messages shows Expand/Collapse in Thread List view Nov 22, 2021
@germain-gg germain-gg added this to the App team 1.9.6 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants