Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS hotkey for Go to Home View is surprising, should use Command instead of Control #19850

Closed
lilyball opened this issue Nov 22, 2021 · 6 comments · Fixed by matrix-org/matrix-react-sdk#7631
Closed

macOS hotkey for Go to Home View is surprising, should use Command instead of Control #19850

lilyball opened this issue Nov 22, 2021 · 6 comments · Fixed by matrix-org/matrix-react-sdk#7631
Assignees
@aj-ya
Labels
A11y A-Shortcuts Keyboard shortcuts A-Spaces Spaces, groups, communities good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Platform-Specific

Comments

@lilyball
Copy link

Steps to reproduce

  1. Run the app on macOS
  2. Press ⇧⌘H

Outcome

What did you expect?

It should have gone to the Home View

What happened instead?

Nothing at all, because the shortcut is actually ⌃⇧H

The other shortcuts use the Command key as appropriate, this is the only one that uses Control inappropriately. The other hotkeys using Control are modifiers on the arrow keys, which is fine.

Operating system

macOS

Application version

Version 1.9.5

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@SimonBrandner SimonBrandner added A-Shortcuts Keyboard shortcuts A11y O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Platform-Specific S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 23, 2021
@germain-gg germain-gg added the A-Spaces Spaces, groups, communities label Nov 23, 2021
@kittykat kittykat added the Help Wanted Extra attention is needed label Jan 21, 2022
@kittykat
Copy link
Contributor

Yes, this should be resolved by updating the shortcut to ⇧⌘H - issue is ready for development 👍

@t3chguy t3chguy added the good first issue Good for newcomers label Jan 25, 2022
@aj-ya
Copy link

aj-ya commented Jan 25, 2022 •
edited
Loading

Hey @kittykat ! I would like to work on this issue. Could you help me get started.

@SimonBrandner
Copy link
Contributor

Hey @kittykat ! I would like to work on this issue. Could you help me get started.

The relevant files are https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/accessibility/KeyboardShortcuts.ts and https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/KeyBindingsDefaults.ts. Be sure to visit https://matrix.to/#/#element-dev:matrix.org if you need more guidance!

@aj-ya
Copy link

aj-ya commented Jan 26, 2022

Hey! @SimonBrandner Thanks for assigning me to this issue! After going through those files and the issue, I believe I have to bind the 'Go to Home' view to the following key combinations.
on Mac : SHIFT + ⌘ + H ( presently CTRL+SHIFT+H )
on PC: CTRL + ALT + H ( presently CTRL+ALT+H )
Please give me a thumbs up, if I'm right!

@SimonBrandner
Copy link
Contributor

Hey! @SimonBrandner Thanks for assigning me to this issue! After going through those files and the issue, I believe I have to bind the 'Go to Home' view to the following key combinations. on Mac : SHIFT + ⌘ + H ( presently CTRL+SHIFT+H ) on PC: CTRL + ALT + H ( presently CTRL+ALT+H ) Please give me a thumbs up, if I'm right!

Sounds good 👍

@aj-ya aj-ya mentioned this issue Jan 26, 2022
Merged
@aj-ya
Copy link

aj-ya commented Jan 26, 2022

Hey! I've opened a PR regarding this issue. please check it out and give suggestions if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aj-ya aj-ya

Labels
A11y A-Shortcuts Keyboard shortcuts A-Spaces Spaces, groups, communities good first issue Good for newcomers Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Platform-Specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed MacOS hotkey for GoToHome view.
6 participants
@lilyball @kittykat @germain-gg @t3chguy @SimonBrandner @aj-ya