Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging.element.io always reports updates are available #20058

Closed
novocaine opened this issue Dec 6, 2021 · 2 comments · Fixed by #20061
Closed

staging.element.io always reports updates are available #20058

novocaine opened this issue Dec 6, 2021 · 2 comments · Fixed by #20061
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker

Comments

@novocaine
Copy link
Contributor

Steps to reproduce

Visit https://staging.element.io/#/home

See the "Update Element" toast. Click update. Reload the page, go into settings, check for an update, see one is still available.

Outcome

Staging should not be telling me to update when I'm already only latest.

Operating system

OS X

Browser information

Chrome

URL for webapp

staging.element.io

Application version

v1.9.6-rc.2

Homeserver

matrix.org

Will you send logs?

No
@novocaine novocaine mentioned this issue Dec 6, 2021
Closed
@novocaine
Copy link
Contributor Author

novocaine commented Dec 6, 2021 •
edited
Loading

regression caused by #19857

process.env.VERSION is being embedded as v1.9.6-rc.2 in the bundle, which is being compared to 1.9.6-rc.2 (no v) being returned by a /version request

@novocaine novocaine added X-Release-Blocker S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Dec 6, 2021
@novocaine novocaine mentioned this issue Dec 6, 2021
Merged
@novocaine
Copy link
Contributor Author

This doesn't affect nightly/develop because there the versions don't start with a v; this only affects staging and prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize the local app version when checking for updates element-hq/element-web
1 participant
@novocaine