New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgBubbles: Stickers #20523

Closed

daniellekirkwood opened this issue Jan 12, 2022 · 3 comments · Fixed by matrix-org/matrix-react-sdk#7560

Assignees

Labels

A-Message-Bubbles A-Stickers T-Enhancement Z-Labs

Contributor

daniellekirkwood commented Jan 12, 2022 •

edited

Loading

Your use case

As part of the Message Bubbles project, Stickers should not into Bubbles.

daniellekirkwood added T-Enhancement A-Message-Bubbles Z-BubblesTesting labels

daniellekirkwood assigned t3chguy and amshakal

github-actions bot added the Z-Labs label

daniellekirkwood mentioned this issue

Message Bubbles element-hq/element-meta#72

Closed

SimonBrandner added the A-Stickers label

t3chguy mentioned this issue

Linear gradient on images with transparencies in message bubble layout looks bad #20535

Closed

Member

t3chguy commented Jan 13, 2022 •

edited

Loading

One thing to consider is stickers are not unlike images with a transparent border (and a tooltip) so putting them in a bubble that may be inconsistent with sticker-like images which are sent as an m.image instead of m.sticker.
Related #20535

daniellekirkwood mentioned this issue

MsgBubbles: Smoke Testing (Web) #20327

Closed

5 tasks

amshakal commented Jan 17, 2022

Hi, okay based on the issue above and to remove complications. Let's move stickers outside the bubble. On doing some research on other platforms I see floating timestamp for stickers is quite common and perhaps a better tradeoff than having a gradient. The only place where it might not look good is if stick is the first message sent by a user. I am attaching below designs for the those scenarios. Aplogies for going back and forth on this issue. Thanks!

When sticker is the first message

When sticker is a message in between

When sticker is the last message

Link to figma: https://www.figma.com/file/zVtAKK0hzKu5JkpbzlE1pG/Message-Bubbles?node-id=2099%3A44213

t3chguy mentioned this issue

Update bubble layout styling for stickers matrix-org/matrix-react-sdk#7560

Merged

Contributor Author

daniellekirkwood commented Jan 17, 2022

Updated content of issue based on above

t3chguy closed this as completed in matrix-org/matrix-react-sdk#7560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment