-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking on the jump to unreads button throws a Failed to load timeline position
error and dumps me in a blank timeline
#20927
Comments
I just experienced this issue on Desktop Nightly and rageshaked, I think @thegcat also encountered it recently. |
This just happened to me again, and I think the situation was that I had unread messages in a thread in the room where this happened. The "up arrow" on iOS would take me to the room history position where said thread is (I wasn't able to open and read the thread though because that part seems to be currently broken on iOS…), the "up arrow" on desktop tries to take me somewhere, fails and shows a blank timeline as reported above. Reading the thread makes the read marker/"up arrow" disappear. Is it possible that the "up arrow" links to a message that is not shown in the timeline per se but is part of a thread, which then confuses Element Desktop, which then just gives up because it can't comprehend where it should jump back to? |
Failed to load timeline position
error and dumps me in a blank timeline
This just happened to me (rageshake-sent the logs), but interestingly, clicking out of the room, back into the room and then clicking the "jump to first unread message" button worked fine on the second try, even though the unread-messages count had reset to 0. Strange. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Reproduced this again but this time the error is a little different when clicking the jump to unread action (same user-facing reproduction steps and symptoms though):
I noticed that there is a warning for this event that happened earlier in the logs. Why does this even happen?
According to this debug output, the problem event we're trying to jump to (
Full rageshake logs: https://github.com/matrix-org/element-web-rageshakes/issues/20281 |
I rageshook from a few rooms exhibiting this behaviour. |
I think this boils down to bugs in the threads code that will necessitate quite large (likely breaking) changes in the API surface around the context API. Currently you call the context API on a given timeline set and sometimes it fails if the event doesn't fit within that timeline set, e.g. in a different thread. The API needs to be able to return a timeline set rather than just a timeline within the given set to be able to jump between threads/main. |
This issue occurs when your RM Not sure what the desired UX here would be, given threads don't have RMs so one would not expect clicking Needs P&D |
Until a proper fix is available could there be a workaround that, after dismissing the error, dumps users to the last scroll position (or even just the bottom)? Currently the most annoying element of this issue is having to fix the broken room view. |
Clicking on the jump to unreads button throws a
Failed to load timeline position
error and dumps me in a blank timelineRelated to:
Steps to reproduce
Visit a room
Click the "Jump to first unread message."
^
up-arrowFailed to load timeline position
error modal is thrown upAfter exiting out of the modal, the timeline is blank and no way to scroll
Have to switch rooms to get the timeline again
Reproduction/rage-shake logs: https://github.com/matrix-org/element-web-rageshakes/issues/10392
I was in the
!ltpmbfSHehPTwnLDNS:jki.re
room and clicked on the "Jump to first unread message." arrow and got theFailed to load timeline position
error modal. With the following error in the devtools console.Relevant code for the error:
src/components/structures/TimelinePanel.tsx#L1219-L1244
I'm not sure what room the
$iR-8DJRGNhmIpDFDHmRy70gUTurU77eCba-Jt5YIXbo
event pertains to. Is there a way to look it up and tell which room it actually belongs to?Outcome
What did you expect?
Jump to first unread button jumps me to whatever the unreads are for that room. Or not be shown if it was for another room and this room doesn't have any unreads.
What happened instead?
Error modal is shown for a situation that probably shouldn't occur in the first place.
Operating system
Windows 10
Browser information
Chrome 97.0.4692.99
URL for webapp
https://develop.element.io/
Application version
Element version: 64242a0-react-78e78292cb62-js-b07457726bf5 Olm version: 3.2.8
Homeserver
matrix.org
Will you send logs?
Yes ->
The text was updated successfully, but these errors were encountered: