Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

space panel kebab menu is rendered out of view on sub spaces #21141

Closed
kerryarchibald opened this issue Feb 21, 2022 · 15 comments · Fixed by matrix-org/matrix-react-sdk#8350
Closed

space panel kebab menu is rendered out of view on sub spaces #21141

kerryarchibald opened this issue Feb 21, 2022 · 15 comments · Fixed by matrix-org/matrix-react-sdk#8350
Assignees
@yaya-usman
Labels
A-Spaces Spaces, groups, communities A-Subspaces Spaces which are inside other spaces good first issue Good for newcomers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@kerryarchibald
Copy link
Contributor

Steps to reproduce

Screen.Recording.2022-02-21.at.16.08.26.mov

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@kerryarchibald kerryarchibald added T-Defect A-Spaces Spaces, groups, communities labels Feb 21, 2022
@HarHarLinks
Copy link

This does not happen for me on Element Nightly version: 2022022001 so probably regressed since then

@t3chguy t3chguy added the A-Subspaces Spaces which are inside other spaces label Feb 21, 2022
@SimonBrandner SimonBrandner added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 21, 2022
@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 22, 2022
@germain-gg
Copy link
Contributor

Downgrading to minor as I don't believe this is a major feature and you can right click on the space itself to display the context menu

@t3chguy
Copy link
Member

t3chguy commented Feb 22, 2022

Also subspaces are still marked as Beta

@andybalaam andybalaam added the good first issue Good for newcomers label Mar 30, 2022
@yaya-usman
Copy link
Contributor

@andybalaam @t3chguy can i get assigned this issue?

@SimonBrandner
Copy link
Contributor

@andybalaam @t3chguy can i get assigned this issue?

I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!

@yaya-usman
Copy link
Contributor

@andybalaam @t3chguy can i get assigned this issue?

I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!

Thanks @SimonBrandner, can you pls direct me on how to make a nested chats or rooms like that, I can't seem to do that, when I tried that yesterday

@SimonBrandner
Copy link
Contributor

Peek.2022-03-31.17-24.mp4

Like so

@yaya-usman
Copy link
Contributor

Peek.2022-03-31.17-24.mp4
Like so

Alright thanks.

@yaya-usman
Copy link
Contributor

@SimonBrandner can you please check again if it still happens for you... I tried again reproducing, i couldn't. I await your response thanks.

@HarHarLinks
Copy link

It does still happen
image
Element Nightly version: 2022041601
Olm version: 3.2.8

@yaya-usman
Copy link
Contributor

It does still happen image Element Nightly version: 2022041601 Olm version: 3.2.8

Alright thanks.

@yaya-usman
Copy link
Contributor

@HarHarLinks One more question, what behavior would you guys want this to exhibit instead when subspaces name get longer. I am trying to think of a fix. I would appreciate any suggestion

@HarHarLinks
Copy link

HarHarLinks commented Apr 16, 2022 •
edited
Loading

image
Subspace names are ellipses (red) anyway, it just needs to be adjusted (to happen early enough) so the kebab menu (green) is where it should be

@SimonBrandner
Copy link
Contributor

@yaya-usman, I am unassigning you until there is at least a draft PR linked to the issue

@yaya-usman
Copy link
Contributor

Dropping a PR now, i just wanted to be clear of what the supposed behavior should be

@yaya-usman yaya-usman mentioned this issue Apr 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaya-usman yaya-usman

Labels
A-Spaces Spaces, groups, communities A-Subspaces Spaces which are inside other spaces good first issue Good for newcomers O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes "space panel kebab menu is rendered out of view on sub spaces" yaya-usman/matrix-react-sdk
7 participants
@andybalaam @germain-gg @t3chguy @HarHarLinks @kerryarchibald @SimonBrandner @yaya-usman