Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username highlights on the dark theme look bad due to brownish colour #21806

Open
dkasak opened this issue Apr 14, 2022 · 4 comments
Open

Username highlights on the dark theme look bad due to brownish colour #21806

dkasak opened this issue Apr 14, 2022 · 4 comments
Labels
A11y A-Notifications A-Themes-Official Official themes (light, dark) A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users X-Needs-Design

Comments

@dkasak
Copy link
Member

dkasak commented Apr 14, 2022

Username highlights on the dark theme look bad while unselected due to the brownish background colour which stands out from the rest of the theme:

unselected

It's a bit better when selected since it then changes to a grey shade:

selected

I think this is just dark theme bug stemming from the colour not being handpicked but brought over from the light theme.

I originally mentioned this at #8554 (comment), which got closed.

@dkasak dkasak added X-Needs-Design A-Themes-Official Official themes (light, dark) labels Apr 14, 2022
@SimonBrandner
Copy link
Contributor

I believe that the reddish-brownish colour is intentional - it's supposed to catch your attention, the light theme has something similar

@SimonBrandner SimonBrandner added X-Needs-Info This issue is blocked awaiting information from the reporter A-Timeline A-Notifications labels Apr 15, 2022
@dkasak
Copy link
Member Author

dkasak commented Apr 15, 2022

The red is not problematic, but the brownish colour just looks completely out of place in combination with the rest of the theme. We never use brownish tones anywhere else and it's (IMO) a particularly ugly shade.

In the light theme, a yellowish shade is used which works much better.

@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Apr 15, 2022
@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2022

That looks like its a translucent yellow, which mixed with the bg looks brownish

@dkasak
Copy link
Member Author

dkasak commented Apr 19, 2022

Yes, which made me think this is because the colour was just brought over from the light theme without any adjustments to make it look good on the dark theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-Notifications A-Themes-Official Official themes (light, dark) A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users X-Needs-Design
Projects
None yet
Development

No branches or pull requests

4 participants