Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message and pill from historical profile not highlighted #21808

Open
MadLittleMods opened this issue Apr 14, 2022 · 0 comments
Open

Message and pill from historical profile not highlighted #21808

MadLittleMods opened this issue Apr 14, 2022 · 0 comments
Labels
A-Notifications A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Apr 14, 2022

Steps to reproduce

  1. Have someone mention your user with a pill
  2. Change your display name to something unrelated like flyingbutterfly
  3. Have someone mention your user with a pill (the pill should be your new display name now)
  4. Change your display name back to your original name
  5. Refresh the page, maybe a couple of times
  6. Notice how the message and pill from when your display name was different isn't highlighted red anymore

Outcome

What did you expect?

Pills for all historical profiles of me are highlighted.

What happened instead?

The screenshot is from the perspective of erictroupetester user who changed their name to flyingbutterfly. After the refresh, all of the pills also show erictroupetester instead of the historical profile at the time (this is tracked by #4677) (I don't have the feature_use_only_current_profiles Lab enabled)

Problem message source for reference:

{
  "type": "m.room.message",
  "room_id": "!HBehERstyQBxyJDLfR:my.synapse.server",
  "sender": "@ericgittertester:my.synapse.server",
  "content": {
    "org.matrix.msc1767.message": [
      {
        "body": "flyingbutterfly: direct pill mention",
        "mimetype": "text/plain"
      },
      {
        "body": "<a href=\"https://matrix.to/#/@erictroupetester:my.synapse.server\">flyingbutterfly</a>: direct pill mention",
        "mimetype": "text/html"
      }
    ],
    "body": "flyingbutterfly: direct pill mention",
    "msgtype": "m.text",
    "format": "org.matrix.custom.html",
    "formatted_body": "<a href=\"https://matrix.to/#/@erictroupetester:my.synapse.server\">flyingbutterfly</a>: direct pill mention"
  },
  "origin_server_ts": 1649964056179,
  "unsigned": {
    "age": 5834917
  },
  "event_id": "$zTz0pkbepiOiTWOl1xrgEJGu99okiFtZ5_My1jFIsuc",
  "user_id": "@ericgittertester:my.synapse.server",
  "age": 5834917
}

Operating system

macOS 12.3

Browser information

Chrome version 100.0.4896.75

URL for webapp

http://localhost:8080/

Application version

Latest develop from 2022-04-13

Homeserver

localhost

Will you send logs?

No

@MadLittleMods MadLittleMods added T-Defect S-Tolerable Low/no impact on users A-Notifications A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Pills O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

1 participant