Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Sliding Sync in Element Web #22264

Closed
2 of 4 tasks
Tracked by #246
novocaine opened this issue May 18, 2022 · 11 comments
Closed
2 of 4 tasks
Tracked by #246

[Epic] Sliding Sync in Element Web #22264

novocaine opened this issue May 18, 2022 · 11 comments
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement T-Epic Issue is at Epic level Z-AirFocus Moving issues from GH to AirFocus purposefully using this tag.

Comments

@novocaine
Copy link
Contributor

novocaine commented May 18, 2022

Why?

Sync performance is poor, both on initial and incremental syncs, and scales linearly with the number of joined rooms.

What?

We’ll integrate support for Sliding Sync which provides a sync mechanism that scales independently of the number of rooms, enabling higher performance for all syncs.

Plan

  • Initial spike: Implement MSC3575: Sliding Sync matrix-org/matrix-react-sdk#8328
  • Implement support for MSC3575 in Element Web
  • Read proxy URL from .well-known/matrix/client, enabling SS by default if some default: true flag is set on the response, otherwise, keep it toggleable in labs
  • Deploy the proxy to :element.io which then advertises the proxy so Element people can play with it very easily

Internal references

@novocaine novocaine added T-Enhancement T-Epic Issue is at Epic level labels May 18, 2022
@andybalaam andybalaam added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels May 19, 2022
@kegsay
Copy link
Contributor

kegsay commented Jan 19, 2023

So this has been in Labs for a while now, and isn't on a branch anymore. At the weekly discussion today we decided that this issue can be closed when:

  • EW looks at the .well-known/matrix/client response and pulls the proxy URL from it, enabling it by default if some default: true flag is set on the response. Otherwise, keep it toggleable in Labs.
  • Deploy the proxy to :element.io which then advertises the proxy so Element people can play with it very easily.

@Johennes Johennes changed the title Implement support for MSC3575 Sliding Sync in Element Web Epic: Sliding Sync in Element Web (MSC3575) Jan 23, 2023
@Johennes
Copy link
Contributor

Thanks @kegsay. I've updated the checklist in the description above. Do you rely on help from the app team for the remaining tasks?

@Johennes
Copy link
Contributor

From talking to @andybalaam it sounds like the answer is no for now.

@daniellekirkwood daniellekirkwood added the Z-AirFocus Moving issues from GH to AirFocus purposefully using this tag. label Feb 2, 2023
@Johennes
Copy link
Contributor

Johennes commented May 4, 2023

I'm removing this from the WAT project because empirically we haven't really needed to do much / anything out of the WAT to move this forward. Consequently, there's not much value in tracking it in our roadmap.

@kegsay
Copy link
Contributor

kegsay commented May 17, 2023

This is mostly on me to deploy the SS proxy to :element.io and get EW looking at .well-known. The former is blocked on OIDC support which is being deployed to :matrix.org today. The latter isn't blocked on anything and could be done by anyone, but will probably be me.

@grinapo
Copy link

grinapo commented Oct 26, 2023

Is it possible to labs-enable it on released EW, suing self server/ssync proxy? Anything else needed to test apart from enabling?

@t3chguy
Copy link
Member

t3chguy commented Oct 26, 2023

@daniellekirkwood daniellekirkwood changed the title Epic: Sliding Sync in Element Web (MSC3575) [Epic] Sliding Sync in Element Web Nov 13, 2023
@eternaleye
Copy link

Does the sliding sync proxy need to be deployed on element.io? Or would it suffice for the sliding sync proxy that is deployed on matrix.org already at https://slidingsync.lab.matrix.org (and which is listed in the .well-known entry) to add the necessary CORS headers permitting Element Web to make use of it?

@t3chguy
Copy link
Member

t3chguy commented Jan 12, 2024

@eternaleye the sliding proxy only connects to one server, so you cannot use https://slidingsync.lab.matrix.org/ for servers other than the one it connects to, which you can check using https://slidingsync.lab.matrix.org/client/server.json "server": "https://matrix-client.matrix.org",

@EdGeraghty
Copy link
Contributor

Hi, I wrote a patch to read the .well-known.

It's going to need a bit of TLC from someone who knows what they're doing, but this at least allows me to enable sliding sync from labs!

matrix-org/matrix-react-sdk#12307

@dbkr
Copy link
Member

dbkr commented Dec 13, 2024

Closing this in favour of a fresh one, #28736 which tracks simplified sliding sync.

@dbkr dbkr closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement T-Epic Issue is at Epic level Z-AirFocus Moving issues from GH to AirFocus purposefully using this tag.
Projects
None yet
Development

No branches or pull requests

10 participants