Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touch area to close the settings dialog is too small. #22915

Open
bmarty opened this issue Jul 22, 2022 · 4 comments
Open

Touch area to close the settings dialog is too small. #22915

bmarty opened this issue Jul 22, 2022 · 4 comments
Labels
A-Dialogs Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@bmarty
Copy link
Member

bmarty commented Jul 22, 2022 •
edited
Loading

Steps to reproduce

  1. Open the setting
  2. Try to close the dialog clicking on the cross at top right

Outcome

What did you expect?

I can click on the top right corner of the setting dialog, even if not exactly on the small cross to close the dialog

What happened instead?

Touch area is too small and there is no hover effect

image

Operating system

all

Browser information

all

URL for webapp

develop.element.io

Application version

Element version: 1519d56-react-be0f4a1fe52f-js-32bb4b1fc464 Olm version: 3.2.8

Homeserver

any

Will you send logs?

No
@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely good first issue Good for newcomers A-Dialogs labels Jul 23, 2022
@gefgu gefgu mentioned this issue Aug 17, 2022
Closed
3 tasks
@kittykat kittykat added the Help Wanted Extra attention is needed label Sep 23, 2022
@Sanketh149
Copy link

I am interested to work on this issue. Please assign me..

@t3chguy
Copy link
Member

t3chguy commented Jan 30, 2023

@Sanketh149

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

@Shubham-Rasal
Copy link

Hey @Sanketh149, let me know if you are still working on it. Otherwise, I would like to solve this issue.

@BalanaguYashwanth BalanaguYashwanth mentioned this issue Feb 12, 2023
Closed
3 tasks
@Manish254252
Copy link

Hello Anyone Working on this ?

@germain-gg germain-gg removed the good first issue Good for newcomers label Feb 13, 2023
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Dialogs Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
9 participants
@kittykat @germain-gg @Johennes @t3chguy @bmarty @SimonBrandner @Manish254252 @Sanketh149 @Shubham-Rasal