-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quoted content (> xxx) should be displayed in higher contrast #23302
Comments
Related: #19522 |
@rufuskahler This is being addressed internally in the design team as part of the work on the new color system, along with many other changes. Do we need to keep a separate issue for this one? |
Fixed by matrix-org/matrix-react-sdk#11079 |
Was this fix part of Element version 1.11.37? If so, I'm not seeing any discernable change there. |
The commit from the linked PR is definitely in the release |
@eras what did you expect? This now passes the WCAG AA contrast check and also uses a bigger font-size. This should have improved legibility. |
Your use case
What would you like to do?
When quoting context for a message with
> xxx
I would like the output to have higher contrast.
Why would you like to do it?
I think low contrast color was chosen due to replies repeating the existing content and thus this is considered to be less important; however context is important and sometimes the quoted content originates from other sources, such as documents. However, nowadays quoted replies are actually rendered in a higher contrast color. It's only the normally quoted content that has less contrast.
Example of low contrast in dark theme (same applies for light theme unless it's been changed at some point, which I doubt):
Use a brighter color (in dark theme, obviously the reverse in light theme); indeed it could be just as bright as normal text, there is already a quotation symbol on the left. Could be different color. Just not be as low contrast.
This could also be an accessibility concern.
Also: Slack uses high contrast :).
How would you like to achieve it?
Covered already.
This has been a long-time personal wee frustration with it, but perhaps if others feel the same way this could be fixed.
Have you considered any alternatives?
Modifying the CSS directly or enabling custom theming from the labs would solve this issue for me, but I feel this should be something "correct" right out of the box.
There could be a tunable for this in Settings/Appearance.
Additional context
No response
The text was updated successfully, but these errors were encountered: