Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image sent as a reply appears out of a bubble #23409

Open
daniellekirkwood opened this issue Oct 4, 2022 · 3 comments
Open

Image sent as a reply appears out of a bubble #23409

daniellekirkwood opened this issue Oct 4, 2022 · 3 comments
Labels
A-Message-Bubbles O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design

Comments

@daniellekirkwood
Copy link
Contributor

Steps to reproduce

Screenshot 2022-10-04 at 09 51 28

I have bubbles on - when I received an reply that was an image the reply text is not in a bubble...

I assume this is something to do with the gradient being removed from the bubble as I don't think we've touched anything else WRT message bubbles recently and this wasn't happening before...

Outcome

What did you expect?

Text inside a bubble

What happened instead?

Text like a view without bubbles

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No

@ShadowJonathan
Copy link
Contributor

Just for clarification because it confused me; the grey-blueish colour that wraps the first message is a normal bubble colour, it should also be the wrapping to the second message with the image.

@robintown
Copy link
Member

This was happening before—see #21581. The designs just have never accounted for image replies, since replying with an image was a feature added after the initial prototypes of bubble layout.

@robintown robintown changed the title Image sent as a reply now appears out of a bubble Image sent as a reply appears out of a bubble Oct 4, 2022
@daniellekirkwood
Copy link
Contributor Author

@amshakal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Bubbles O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Needs-Design
Projects
None yet
Development

No branches or pull requests

4 participants