Notication keywords trigger on homeserver domain in MXID

[BurnyBoi]

Steps to reproduce

1. Add a notification keyword that is a word in the domain section of anybody's MXID
2. Have someone reply to anyone other than you with that domain in their MXID

(Example: Add matrix as a notification keyword, then have anyone reply to a matrix.org user)

Outcome

What did you expect?

User should NOT get a notification, because the body of the original message and the reply do not contain matrix (in the example given)

What happened instead?

I receive a notification because the user being replied to has matrix in the domain of their MXID, triggering the keyword.

Message being replied to (Example 1):

Example 2 (with reply that causes a notification):

(Note: Neither of these are my account. The notification is only because the one being replied to is on matrix.org)

Operating system

Arch Linux

Browser information

Firefox 105

URL for webapp

develop.element.io

Application version

Element version: 2ef6abb-react-8b54be6f4863-js-cc025ea45844 Olm version: 3.2.12

Homeserver

matrix.org

Will you send logs?

No

[MadLittleMods]

In the second example with the reply, it makes more sense why it would ping you since the reply syntax has the MXID in it with matrix.org.

event.content.body

> <@madlittlemods:matrix.org> foo\n\nbar

event.content.formatted_body

<mx-reply>
	<blockquote>
		<a href="https://matrix.to/#/!xxx:matrix.org/$123?via=matrix.org">In reply to</a>
		<a href="https://matrix.to/#/@madlittlemods:matrix.org">@madlittlemods:matrix.org</a>
		<br>foo
	</blockquote>
</mx-reply>

bar

---

For the first example, I'm not able to reproduce with from a normal message that has no matrix string in the body. Can you share the source for that message? Are you absolutely sure that you got a notification sound for it? Can you reproduce with another plain message?

[BurnyBoi]

For the first example, I'm not able to reproduce with from a normal message that has no matrix string in the body. Can you share the source for that message? Are you absolutely sure that you got a notification sound for it? Can you reproduce with another plain message?

@MadLittleMods The first message is not causing a notification. It just has the green on the left because I clicked the reply to get to it. I just screenshot that one so I could prove the entire message does not contain "matrix" in it. This bug is only about the reply causing a notification.

While the formatted body may technically contain the MXID in the event body and does explain why the bug happens, it's not being presented that way to the user, and neither message actually contains "matrix" from the user's perspective.

[MadLittleMods]

Thanks for the clarification @BurnyBoi!

Looks like a duplicate of element-hq/element-meta#743, #16863, element-hq/element-meta#744