Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji picker seems to occasionally make absurd suggestions #23680

Closed
ell1e opened this issue Nov 2, 2022 · 3 comments
Closed

Emoji picker seems to occasionally make absurd suggestions #23680

ell1e opened this issue Nov 2, 2022 · 3 comments
Labels
A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@ell1e
Copy link

ell1e commented Nov 2, 2022

Steps to reproduce

  1. Type :wea
  2. Check out what the emoji picker suggests

Outcome

What did you expect?

If I typed something that matches exactly the beginning of any emoji names, those should be the top results above others. If it matches exactly a substring of any emoji names at least, those should also sorted above any others where it doesn't.

What happened instead?

:scream_cat:? For :wear? I don't know, to me that seems a little absurd, there isn't even a w anywhere in :scream_cat: so it's neither a prefix nor substring match and yet it's at the top(??):
Screenshot from 2022-11-02 08-45-04
I just can't really imagine anyone finding that top suggestion fitting or expected.

Operating system

Linux

Application version

Element version: 1.11.10 Olm version: 3.2.12

How did you install the app?

flatpak/flathub

Homeserver

matrix.org

Will you send logs?

No

@ell1e ell1e added the T-Defect label Nov 2, 2022
@weeman1337
Copy link
Contributor

The reason for this showing up is that the emoji is called „Weary Cat“ 🙀

image

Not seeing this information in the inline picker can lead to the confusion. I think this needs to be decided by design/product.

@weeman1337 weeman1337 added S-Tolerable Low/no impact on users A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 2, 2022
@ell1e
Copy link
Author

ell1e commented Nov 2, 2022

Even then, :weary: is the shorter match so I'd argue it should be at the top. If the other one was e.g. named :wearycat: then it should be 2nd, not 1st. I also think that the :...: colon like names should be higher priority for sorting the results than whatever other "speaking name" the emoji might have.

Edit: also as a side note, how about having it renamed anyway? That cat looks way more screaming than just weary, so that name seems a little surprising.

@grimhilt
Copy link

grimhilt commented Mar 9, 2023

Fixed by matrix-org/matrix-react-sdk#10212 ?

@t3chguy t3chguy closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Emoji O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants