Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms and getRoomUpgradeHistory #24417

Closed
14 tasks done
Tracked by #24262
andybalaam opened this issue Feb 2, 2023 · 2 comments
Closed
14 tasks done
Tracked by #24262

Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms and getRoomUpgradeHistory #24417

andybalaam opened this issue Feb 2, 2023 · 2 comments
Assignees
@andybalaam
Labels
A-Room-Upgrades O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Gitter Issues relating to or coming out of the Gitter migration, feature parity, etc

Comments

@andybalaam
Copy link
Member

andybalaam commented Feb 2, 2023 •
edited
Loading

Towards MSC3946

Pass the MSC3946 feature flag in wherever we call getVisibleRooms and getRoomUpgradeHistory.

There may be a unified way we should approach this, but the code locations that call one or both of these functions are here:

  • src/stores/BreadcrumbsStore.ts - PR10295
  • src/stores/notifications/RoomNotificationStateStore.ts PR10297
  • src/stores/widgets/WidgetLayoutStore.ts PR10326
  • src/stores/spaces/SpaceStore.js PR10332
  • src/stores/widgets/StopGapWidgetDriver.ts PR10338
  • src/stores/OwnBeaconStore.ts PR10339
  • src/utils/leave-behaviour.ts PR10340
  • src/components/structures/SpaceHierarchy.tsx PR10341
  • src/stores/room-list/RoomListStore.ts
  • src/components/views/dialogs/AddExistingToSpaceDialog.tsx PR10342
  • src/components/views/dialogs/spotlight/SpotlightDialog.tsx
  • src/components/views/dialogs/ForwardDialog.tsx PR10344
  • src/autocomplete/RoomProvider.tsx PR10346
  • src/autocomplete/SpaceProvider.tsx PR10348
@andybalaam andybalaam self-assigned this Feb 2, 2023
@andybalaam andybalaam changed the title Pass feature flag through to everywhere we use getVisibleRooms Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms Feb 2, 2023
@robintown robintown added T-Defect A-Room-Upgrades S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 2, 2023
@andybalaam andybalaam mentioned this issue Feb 3, 2023
Merged
@andybalaam andybalaam changed the title Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms Gitter sunsetting: Pass feature flag through to everywhere we use getVisibleRooms and getRoomUpgradeHistory Feb 3, 2023
@andybalaam andybalaam mentioned this issue Feb 3, 2023
Closed
4 tasks
@andybalaam
Copy link
Member Author

At first glance, none of the above except the 2 already-completed items (RoomListStore.ts and SpotlightDialog.tsx) look crucial for Gitter sunsetting to go ahead.

@Johennes Johennes mentioned this issue Feb 10, 2023
Closed
@MadLittleMods MadLittleMods added the Z-Gitter Issues relating to or coming out of the Gitter migration, feature parity, etc label Feb 14, 2023
This was referenced Mar 6, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@andybalaam
Copy link
Member Author

Done. Element-Web should now treat room predecessors consistently everywhere: either using MSC3946 if the labs flag is on, or not if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andybalaam andybalaam

Labels
A-Room-Upgrades O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Gitter Issues relating to or coming out of the Gitter migration, feature parity, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andybalaam @MadLittleMods @robintown