Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hard-coded font-size values with variables specified on _font-sizes.pcss #25072

Closed
luixxiul opened this issue Apr 9, 2023 · 1 comment
Closed

Replace hard-coded font-size values with variables specified on _font-sizes.pcss #25072

luixxiul opened this issue Apr 9, 2023 · 1 comment
Labels
A-Developer-Experience T-Enhancement

Comments

@luixxiul
Copy link

luixxiul commented Apr 9, 2023 •
edited
Loading

Your use case

What would you like to do?

Replace hard-coded font-size values with variables specified on _font-sizes.pcss.

Why would you like to do it?

Because the style guide suggests you to use a variable for a font property. It should also help us to maintain the themes' consistency.

How would you like to achieve it?

Search the values and replace them.

Have you considered any alternatives?

No response

Additional context

This should be one of the tasks for #21656.
@luixxiul luixxiul mentioned this issue Apr 9, 2023
Closed
3 tasks
@luixxiul
Copy link
Author

Closing as I believe this must be irrelevant for Compound stuff.

@luixxiul luixxiul closed this as not planned Won't fix, can't repro, duplicate, stale Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Sass variables and hard-coded values with CSS custom properties - _font-sizes.pcss
2 participants
@luixxiul @weeman1337