Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing between rows around the theme switcher on Appearance user settings tab is not consistent #25460

Closed
luixxiul opened this issue May 28, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11676
Closed

Spacing between rows around the theme switcher on Appearance user settings tab is not consistent #25460

luixxiul opened this issue May 28, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11676
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@luixxiul
Copy link

Steps to reproduce

  1. Open Appearance user settings tab

Outcome

What did you expect?

Consistent spacing between rows around the theme switcher.

What happened instead?

The spacing between the rows is not consistent:

1_1

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No
@weeman1337 weeman1337 added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 30, 2023
@manancodes manancodes mentioned this issue Sep 27, 2023
Merged
3 tasks
@manancodes
Copy link

The space inside the theme selectors needed some alignment, I have created a PR for that.

Do you think the spacing between the "Match system theme" and the selectors should also change?

Current UI:
Before

Proposed UI:
After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Theme selector radio button not aligned in center with the text manancodes/matrix-react-sdk
3 participants
@luixxiul @weeman1337 @manancodes