Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sender's display name in image viewer is not readable #25822

Closed
robintown opened this issue Jul 18, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11289
Closed

Sender's display name in image viewer is not readable #25822

robintown opened this issue Jul 18, 2023 · 0 comments · Fixed by matrix-org/matrix-react-sdk#11289
Assignees
@germain-gg
Labels
A11y A-Light-Box UI when viewing an image O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@robintown
Copy link
Member

robintown commented Jul 18, 2023 •
edited
Loading

Steps to reproduce

  1. Use dark mode
  2. Receive an image from someone
  3. Click on it to open it in the image viewer
  4. Look at the sender's display name in the upper left corner

Outcome

What did you expect?

Their display name should have plenty of contrast against the background

What happened instead?

It's unreadable:

Screenshot 2023-07-17 at 22-30-46 Element 7 Test room

Operating system

NixOS unstable

Browser information

Firefox 115.0

URL for webapp

develop.element.io

Application version

Element version: 4cf4dc9-react-ba90e0b25505-js-eb7faa6c0771 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A11y O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Light-Box UI when viewing an image labels Jul 18, 2023
@germain-gg germain-gg self-assigned this Jul 18, 2023
@germain-gg germain-gg mentioned this issue Jul 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A11y A-Light-Box UI when viewing an image O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore color for sender in imageview matrix-org/matrix-react-sdk
2 participants
@germain-gg @robintown