Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIF label is now dark-on-grey on dark theme #25836

Closed
ara4n opened this issue Jul 23, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11312
Closed

GIF label is now dark-on-grey on dark theme #25836

ara4n opened this issue Jul 23, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11312
Assignees
@germain-gg
Labels
A11y O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Jul 23, 2023

Steps to reproduce

Compound seems to have made dark-theme EW show the GIF label on images as black-on-grey:

Screenshot 2023-07-22 at 17 34 45

Outcome

What did you expect?

legible label

Operating system

No response

Application version

July 22 nightly

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@ara4n ara4n added the T-Defect label Jul 23, 2023
@germain-gg germain-gg self-assigned this Jul 24, 2023
@germain-gg
Copy link
Contributor

@janogarcia here's another example of where we need the inverted tokens

@germain-gg germain-gg mentioned this issue Jul 25, 2023
Merged
3 tasks
@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A11y O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GIF label on dark theme matrix-org/matrix-react-sdk
4 participants
@kittykat @germain-gg @ara4n @t3chguy