Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatars in user info panel are 30x30 #26051

Closed
turt2live opened this issue Aug 24, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11473
Closed

Avatars in user info panel are 30x30 #26051

turt2live opened this issue Aug 24, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11473
Assignees
Labels
A-Avatar A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker Z-Compound

Comments

@turt2live
Copy link
Member

turt2live commented Aug 24, 2023

Steps to reproduce

  1. Click on someone's avatar in the timeline to bring up user info
  2. Blurry image

Outcome

What did you expect?

A decent image. Historically we've tried to calculate avatar size for that panel specifically as it's bound by panel width

What happened instead?

image

URL of avatar: https://t2l.io/_matrix/media/v3/thumbnail/t2l.io/fYhaPLjAZLwEYqaSGKwRpQgk?width=30&height=30&method=scale

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023082401 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No

@germain-gg germain-gg self-assigned this Aug 24, 2023
@germain-gg germain-gg added X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Right-Panel A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely labels Aug 24, 2023
@germain-gg
Copy link
Contributor

germain-gg commented Aug 25, 2023

I have not been able to reproduce this, could you check and share the logs in your console?

We can pass a list of URLs to the avatar component and if the first one fails it tries to load the second one.

@weeman1337
Copy link
Contributor

weeman1337 commented Aug 25, 2023

I have not been able to reproduce this, could you check and share the logs in your console?

We can pass a list of URLs to the avatar component and if the first one fails it tries to load the second one.

I can reproduce. It does request the avatar with 30px width from the server. Nothing fancy in console. In the network logs it only requests the 30px version.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker Z-Compound
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants