Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing room search from right panel doesn't change timeline view #26105

Closed
kerryarchibald opened this issue Sep 4, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11605
Closed

Closing room search from right panel doesn't change timeline view #26105

kerryarchibald opened this issue Sep 4, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11605
Assignees
@t3chguy
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression Z-Labs

Comments

@kerryarchibald
Copy link
Contributor

kerryarchibald commented Sep 4, 2023 •
edited
Loading

Steps to reproduce

  1. Open a room, open the right panel
  2. Click 'Search'
  3. Submit a search and wait for results
Screenshot 2023-09-04 at 18 10 19
  1. Toggle search by clicking 'Search' in the right panel
  2. Search bar goes away, but timeline view is still search results without any way to go back to room timeline
Screenshot 2023-09-04 at 18 10 31

Outcome

What did you expect?

Toggling search from sidebar should revert timeline back to normal view.

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No
@kerryarchibald
Copy link
Contributor Author

matrix-org/matrix-react-sdk#11507

@t3chguy t3chguy self-assigned this Sep 4, 2023
@t3chguy t3chguy mentioned this issue Sep 4, 2023
Merged
@t3chguy t3chguy assigned germain-gg and unassigned t3chguy Sep 4, 2023
@t3chguy
Copy link
Member

t3chguy commented Sep 4, 2023

matrix-org/matrix-react-sdk#11524 makes this only a problem for the labs flag

@t3chguy t3chguy mentioned this issue Sep 4, 2023
Merged
3 tasks
@github-actions github-actions bot removed the Z-Labs label Sep 4, 2023
@t3chguy t3chguy added the Z-Labs label Sep 5, 2023
@kittykat kittykat added S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 7, 2023
@t3chguy t3chguy assigned t3chguy and unassigned t3chguy and germain-gg Sep 12, 2023
@t3chguy t3chguy mentioned this issue Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix room timeline search toggling behaviour edge case matrix-org/matrix-react-sdk
4 participants
@kittykat @germain-gg @t3chguy @kerryarchibald